fix(git-clone): propagate pre/post-clone script failures#891
Conversation
|
Hey, thanks for looking into this! The root cause here is actually that @ikkz Would you be open to swapping the approach to just add |
|
@DevelopmentCats Updated as suggested. Added Also, once this PR is merged, when should we expect the new |
Once we merge this PR I will immediately go and release this Module and it should be available a few minutes after that. |
|
@ikkz Should show up on the registry within the next 10 mins. |
|
Thank you! Much appreciated. |
Description
Fix git-clone module to fail fast when
pre_clone_scriptorpost_clone_scriptreturns a non-zero exit code. Previously, both scripts were executed but their exit codes were never checked — a failing pre-clone hook (e.g., a prerequisite check that callsexit 1) was silently ignored and cloning continued. This broke the advertised "validate prerequisites before cloning" behavior and could leave workspaces starting with unmet preconditions.Type of Change
Module Information
Path:
registry/coder/modules/git-cloneNew version:
v1.3.1Breaking change: [ ] Yes [x] No
Testing & Validation
bun test)bun fmt)Related Issues